Handle documented VuMark generation failures - #3120
Merged
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
August 5, 2026 09:36 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
marked this pull request as ready for review
August 5, 2026 09:37
adamtheturtle
temporarily deployed
to
development
August 5, 2026 10:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3090.
Previously, documented VuMark generation failure result codes were not registered and therefore surfaced as
KeyError.This adds public exceptions, result-code mappings, and sync/async documentation, then pins
vws-python-mock==2026.8.4.2and tests both clients through its real mocked HTTP routes.Validation:
uv run --extra dev pytest -q(331 passed), the full pre-commit suite with project-scoped vulture, and the full pre-push suite.Note
Low Risk
Additive exception types and mappings with no change to existing error handling paths; covered by new parametrized tests.
Overview
Adds
QuotaExceededError,LicenseCheckFailedError, andAuthorizationFailedErrorand wires them into the existing Vuforiaresult_code→ exception registry so documented VuMark generation failures surface as typedVWSErrorsubclasses instead ofKeyError.VuMarkServiceandAsyncVuMarkServicedocstrings now document these raises. Dev dependencyvws-python-mockis bumped to 2026.8.4.2; sync and async tests useVuMarkGenerationFailureto assert the right exception and HTTP status for each code.Reviewed by Cursor Bugbot for commit 6fdd76d. Bugbot is set up for automated code reviews on this repo. Configure here.